Force connection close after protocol upgrade #3126
Conversation
tilgovi
force-pushed
the
fix/upgrade-forces-close
branch
2 times, most recently
from
8dcc0fd
to
1ca598d
Compare
|
RFC 6455 states that closing a WebSocket must close the underlying TCP connection:
-- https://datatracker.ietf.org/doc/html/rfc6455#section-5.5.1 I couldn't find any language about this in the HTTP/2 protocol, but it seems safer to me to assume that the socket is in an unknown state and any connection persistence is managed at the level of the new protocol. |
A new protocol, such as WebSockets or HTTP/2, may manage the framing of multiple messages or requests of that protocol over a single connection, but the connection should close once the WSGI callable returns. - Close connections after completion of any upgraded response. - Close connections after a response with status code less than 200. Any such response should be only for a protocol upgrade since applications never see any `Expect` header. - Ensure that the `status_code` member always exists on instances of the `Response` class (close #1210).
tilgovi
force-pushed
the
fix/upgrade-forces-close
branch
from
1ca598d
to
a73b073
Compare
| if self.upgrade: | ||
| # close after the new protocol terminates | ||
| return True | ||
| if self.response_length is None and not self.chunked: |
There was a problem hiding this comment.
why changing the logic there ? Also this doesn't take care anymore about status code < 100. Can you elaborate? (As a side note I'm not a fan of these one line boolean combination, decoupling in multiple if helps to trace the code .
A new protocol, such as WebSockets or HTTP/2, may manage the framing of multiple messages or requests of that protocol over a single connection, but the connection should close once the WSGI callable returns.
Close connections after completion of any upgraded response.
Close connections after a response with status code less than 200. Any such response should be only for a protocol upgrade since applications never see any
Expectheader.Ensure that the
status_codemember always exists on instances of theResponseclass (close 'Response' object has no attribute 'status_code' in wsgi.py with websockets #1210).