Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Pylint 3.x #3110

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CI: Pylint 3.x #3110

wants to merge 5 commits into from

Conversation

pajod
Copy link
Contributor

@pajod pajod commented Dec 8, 2023 •
edited

Most of this PR was already merged in #3131

What remains:

  • pylint 3.0.0 workarounds (because 3.x is what we want for Python 3.12)
  • removing references to ancient Debian releases (updating which is not helpful as long as the versions distributed remain the same)

What is not included but should probably follow after deciding what to do about the signal renaming hack submitted here:

  • Arbiter.SIG_NAMES (stdlib since 3.5 provides signal.Signals Enum) and related comments

@benoitc benoitc self-assigned this Dec 12, 2023
tilgovi
tilgovi requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to just extract the changes to the Python version support and skip the rest, please? I'm not seeing the(pylint comments, inotify import changes, or signal import renaming as relevant to the PR description.

.github/workflows/tox.yml Outdated Show resolved Hide resolved
gunicorn/arbiter.py Show resolved Hide resolved
gunicorn/reloader.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor

cclauss commented Dec 28, 2023

This branch has git conflicts that must be resolved

@tilgovi
Copy link
Collaborator

tilgovi commented Dec 28, 2023

@pajod I'm happy to review the linting-related changes in this PR or separate, your choice. Let's just get the pypy version fixed up and I think we're good to go.

@pajod pajod mentioned this pull request Dec 28, 2023
Merged
@pajod pajod changed the title CI: add CPython 3.12 and PyPy3.10, stop promising untested versions CI: Python 3.12 fixes Dec 28, 2023
@pajod pajod marked this pull request as draft December 28, 2023 20:51
@iM-GeeKy
Copy link

Is there a timeline when this will be merged?

@pajod pajod changed the title CI: Python 3.12 fixes CI: Pylint 3.x Apr 22, 2024
@pajod
modify inotify import branching
711a9d7 
just to ease static code analysis, no functional change intended
@pajod
alias stdblib signal in Class with matching method name
4fdf7eb 
Just to ease static code analysis, no functional change intended. Could have aliases just the other two lines, but chosing the leaked stdlib name ensures nobody should have depended on API stability.
@pajod
pylint: shut up about method-scope cyclic import
30936a4
@pajod
CI: test against Pylint 3.x
e0a9aa1 
Pylint 3.0 is the first version to officially support Python 12
@pajod
docs: remove references to EoL software
f950046 
Debian buster EoL since 2022-09-10
@pajod pajod marked this pull request as ready for review April 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitc benoitc benoitc left review comments

@cclauss cclauss cclauss approved these changes

@tilgovi tilgovi tilgovi requested changes

Assignees

@benoitc benoitc

Labels
To Review working on it :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pajod @cclauss @tilgovi @iM-GeeKy @benoitc