feat: Replace select() usage with poll()
#3010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaseh
force-pushed
the
feat/replace-select-poll
branch
from
91561bb
to
4c7e6b0
Compare
|
select.poll is not supported by some OSs. I suggest to replace hthe usage of select by something more generic like the |
|
the patch looks OK for me. will check it asap.
|
benoitc
requested changes
Feb 15, 2024
| @@ -76,6 +77,8 @@ def __init__(self, app): | |||
| 0: sys.executable | |||
| } | |||
|
|
|||
| self.poller = select.poll() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
select()calls withpoll()in order to resolve #2994 where the server fails to start if the pipe created byarbiter.pyhas a file descriptor number pastFD_SETSIZE(a limitation ofpoll()). Tested by running the test app (gunicorn --workers=2 test:app) and verifying that gunicorn's behavior with respect to signal handling was the same as the master branch.