Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change defaults
SSLContext
to Python'sssl.create_default_context()
and marksssl_version
option as deprecated. The option value will be ignored, and warning will be printed in stderr. The reason for deprecation is thatssl_version
option was depending on old method of setting TLS min/max version. Rationale for ignoring the given value is that the method has not worked well anymore with modern Python versions. See discussion thread #2649 (comment).As an alternative, config file can be used to set the min/max values, for example:
Additionally, this PR fixes some documentation discrepancies by regenerating
settings.rst
fromconfig.py
. The PR also suggests small modification todocs/gunicorn_ext.py
that makes it possible to get sane defaults generated tosettings.rst
foruser
,group
andchdir
options, which otherwise will reset to whatever was effective for the user who regenerated the documentation.