feat(import_app): print original exception on AppImportError #1334
Conversation
| @@ -387,6 +387,8 @@ def import_app(module): | |||
| try: | |||
| app = eval(obj, mod.__dict__) | |||
| except NameError: | |||
| exc_type, exc_value, exc_traceback = sys.exc_info() | |||
| traceback.print_exception(exc_type, exc_value, exc_traceback) | |||
There was a problem hiding this comment.
this should only be done when debug mode is enabled. If not it can expose some unwanted to externals systems looking at the output.
There was a problem hiding this comment.
By debug mode, do you mean checking the logging level ?
There was a problem hiding this comment.
Please either use star args to avoid locals or explicitly delete the traceback. See #1228.
| @@ -387,6 +387,8 @@ def import_app(module): | |||
| try: | |||
| app = eval(obj, mod.__dict__) | |||
| except NameError: | |||
| exc_type, exc_value, exc_traceback = sys.exc_info() | |||
| traceback.print_exception(exc_type, exc_value, exc_traceback) | |||
There was a problem hiding this comment.
Please either use star args to avoid locals or explicitly delete the traceback. See #1228.
|
@ptbrowne I think this is waiting for very minor changes from you. Please let us know if you will have time to do this. |
|
@tilgovi, sorry for the wait, it should be ok now :) |
|
Not a long wait at all, @ptbrowne! I just happened to process this in a batch of commenting on other issues and PRs. I've been high volume, high latency in my attention to Gunicorn lately. Looks good to me. |
…#1334) * feat(import_app): print original exception on AppImportError
Useful when you have a NameError in the code that creates your app.