use EnvironmentError instead of socket.error (closes #939) #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @kaniini. @berkerpeksag can you elaborate on your comment? #939 (comment) Are you concerned that the exception classes are now more general, and might unintentionally catch errors? I think everything is already re-raised correctly if it's not EPIPE or ECONNRESET. |
|
I think EnvironmentError is the most Python 2 and Python 3 compatible way to fix this. We can replace it with OSError when we drop Python 2 support. |
|
👍 In that case, this is good to merge from my perspective. |
berkerpeksag
added a commit
that referenced
this pull request
Feb 2, 2016
use EnvironmentError instead of socket.error (closes #939)
|
Thanks! |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
use EnvironmentError instead of socket.error (closes benoitc#939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges working code to fix the
BrokenPipeErrorexceptions being thrown on Python 3 + eventlet. It has been tested on a large application serving millions of requests hourly.