Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse util.is_fileobject #1175

Merged
merged 2 commits into from Jan 2, 2016
Merged

reuse util.is_fileobject #1175

merged 2 commits into from Jan 2, 2016

Commits on Dec 31, 2015

  1. reuse util.is_fileobject 

    is_fileobject usgae was removed due to the use of the `tell` method check.
This change remove this check wich allows us to completely test if
fileno() is usable. Also it handle most of the exceptions around created by
breaking changes across Python versions. Hopefully we are good now.

fix #1174
    @benoitc
    benoitc committed Dec 31, 2015
    Configuration menu
    Copy the full SHA
    d55ef38 View commit details
    Browse the repository at this point in the history

  2. rename util.is_fileobject to util.has_fileno 

    be more descriptive
    @benoitc
    benoitc committed Dec 31, 2015
    Configuration menu
    Copy the full SHA
    5bc13be View commit details
    Browse the repository at this point in the history