Merge pull request #2991 from Nordix/username-fix

Fix username parsing for basic auth
benoitc · May 11, 2023 · 4aca2e4 · 4aca2e4
2 parents f859de4 + 2b98f5e
commit 4aca2e4
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/gunicorn/glogging.py b/gunicorn/glogging.py
@@ -469,10 +469,7 @@ def _get_user(self, environ):
                     # so we need to convert it to a byte string
                     auth = base64.b64decode(auth[1].strip().encode('utf-8'))
                     # b64decode returns a byte string
-                    auth.split(b":", 1)[0].decode("UTF-8", "replace")
+                    user = auth.split(b":", 1)[0].decode("UTF-8")
                 except (TypeError, binascii.Error, UnicodeDecodeError) as exc:
                     self.debug("Couldn't get username: %s", exc)
-                    return user
-                if len(auth) == 2:
-                    user = auth[0]
         return user