Fix fdopen RuntimeWarning in 3.8

benoitc · Oct 29, 2019 · 2fec665 · 2fec665
1 parent 3fcb551
commit 2fec665
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/gunicorn/workers/workertmp.py b/gunicorn/workers/workertmp.py
@@ -32,7 +32,9 @@ def __init__(self, cfg):
         try:
             if not IS_CYGWIN:
                 util.unlink(name)
-            self._tmp = os.fdopen(fd, 'w+b', 1)
+            # In Python 3.8, open() emits RuntimeWarning if buffering=1 for binary mode.
+            # Because we never write to this file, pass 0 to switch buffering off.
+            self._tmp = os.fdopen(fd, 'w+b', 0)
         except:
             os.close(fd)
             raise