Avoid using Array constructor as a global namespace in @wry/context
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
issue-347-avoid-using-Array-constructor-as-namespace
branch
from
e3ccac3
to
b2a0db3
Compare
benjamn
changed the title
Array constructor as a global namespace
benjamn
changed the title
Array constructor as a global namespaceArray constructor as a global namespace in @wry/context
benjamn
force-pushed
the
issue-347-avoid-using-Array-constructor-as-namespace
branch
2 times, most recently
from
77306c7
to
237aff5
Compare
benjamn
deleted the
issue-347-avoid-using-Array-constructor-as-namespace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #347 by preferring
globalThis[globalKey]andglobal[globalKey](in that order) as the storage location for a singleton copy of theSlotclass, instead of usingArray[globalKey], which was the source of issue #347.In this new implementation, while
Array[globalKey]is consulted for backwards compatibility with simultaneously installed older versions of the@wry/contextpackage (unlikely but possible), theArrayconstructor is no longer modified in any way.