Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inputSourceMap docs/types #703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

flotwig
Copy link

@flotwig flotwig commented Apr 14, 2020

  • inputSourceMap is checked for truthiness in utils and passed to source-map's SourceMapConsumer, which accepts either a JSON string or an object - updated types to allow an object
  • Discussion in fixes #128 extracting inline sourcemap when parsing #146 seems to imply that this does not necessarily need to be a sourcemap generated by recast, despite the language that was previously here

* `inputSourceMap` is checked for truthiness in `utils` and passed to `source-map`'s `SourceMapConsumer`, which accepts either a JSON string or an object - updated types to allow an object
* Discussion in benjamn#501  seems to imply that this does not necessarily need to be a sourcemap generated by `recast`, despite the language that was previously here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant