Fix unit tests that use Function.prototype.toString() #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toString() returns the line endings of the source code on disk, which is not guaranteed to be \n nor \r\n in the absence of .gitattributes
benjamn
approved these changes
May 24, 2018
benjamn
requested changes
Jun 1, 2018
| @@ -272,7 +276,7 @@ describe("lines", function() { | |||
| }); | |||
|
|
|||
| it("Slice", function SliceTest() { | |||
| var code = String(SliceTest), | |||
| var code = functionToString(SliceTest); | |||
| @@ -294,7 +298,7 @@ describe("lines", function() { | |||
| } | |||
|
|
|||
| it("GetSourceLocation", function GetSourceLocationTest() { | |||
| var code = String(GetSourceLocationTest), | |||
| var code = functionToString(GetSourceLocationTest); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function.prototype.toString() returns the line endings of the source code on disk, which is not guaranteed to match
os.EOLwithout a.gitattributesfile.The fix is simple: normalize line endings after calling
toString()to get predictable results.