Add "paths" key in available config keys #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomMoral
reviewed
Apr 21, 2024
|
This would close #627 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 54.30% 54.30%
=======================================
Files 45 45
Lines 2994 2994
Branches 560 560
=======================================
Hits 1626 1626
Misses 1243 1243
Partials 125 125 |
tomMoral
reviewed
May 4, 2024
Comment on lines
+321
to
+323
| paths: | ||
| data: /path/to/data | ||
| """) |
There was a problem hiding this comment.
Suggested change
| paths: | |
| data: /path/to/data | |
| """) | |
| paths: | |
| data: /path/to/data | |
| """) |
Comment on lines
+338
to
+342
| paths = config.get_setting( | ||
| "paths", | ||
| Path("{config_file}"), | ||
| "temp_benchmark" | ||
| ) |
There was a problem hiding this comment.
here, we should use get_data_path
Comment on lines
+296
to
+297
| def get_data_path(key: str = None, config_file=None, benchmark_name=None, | ||
| default_config=None): |
There was a problem hiding this comment.
We should only have parameter key, the other should be inferred from the benchmark.
To get the current benchmark, you can use the novel get_running_benchmark function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the key
pathsin benchmark config.