PLT - Aggregate similar solvers in legend

[Badr-MOUFAD]

This enhances the plotting part:

• Aggregate solvers in legend under the same name
• enable hiding/showing aggregated solvers in legend and plots

Feature preview

• Resnet benchmark
• Lasso Benchmark

next step

• enhance styling
• more complete filtering tool

---

P.S: similar solvers means the same solver run with different parameters

[codecov-commenter]

Codecov Report

Merging #474 (cad1835) into main (4dbec89) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          43       43           
  Lines        2814     2814           
  Branches      516      516           
=======================================
  Hits         1531     1531           
  Misses       1168     1168           
  Partials      115      115           

[Badr-MOUFAD]

@tomMoral, I uploaded the feature preview instead.
Have a look at #474 (comment)

[tomMoral]

When only one is available, I would not create a group no?

[tomMoral]

Also, I liked the previous behavior where the solver tag where all on the same line is not too long :

• Now
  

• Before
  

[Badr-MOUFAD]

@tomMoral, I considered your remarks in the last changes
pls have a look on the feature preview #474 (comment)

[bmalezieux]

When only one is available, I would not create a group no?

I think it is better to keep the group structure to preserve homogeneity. Otherwise, the result looks a bit weird (see the Lasso benchmark in #474)

[Badr-MOUFAD]

I think it is better to keep the group structure to preserve homogeneity. Otherwise, the result looks a bit weird (see the Lasso benchmark in #474)

I managed to restrict the aggregation only for solvers that are run with multiple configurations of parameters
@bmalezieux, could you check whether it renders well for you?

• Resnet benchmark
• Lasso Benchmark

[bmalezieux]

I think it is better to keep the group structure to preserve homogeneity. Otherwise, the result looks a bit weird (see the Lasso benchmark in #474)

I managed to construct groups for solvers that are run with multiple configurations of parameters @bmalezieux, could you check whether it renders well for you?

• Resnet benchmark
• Lasso Benchmark

Actually, I preferred the last version with one block per solver, even with a single configuration. What disturbs me is that the solvers should be represented in the same way in the legend, and this is not the case here in my opinion.

[Badr-MOUFAD]

WDYT @tomMoral?

[tomMoral]

I agree that we should find a consistent way to do this but I don't like the fact that we have to scroll to have the full legend, even when all legend labels could be put on 2/3 lines. This is something we changed 6 months ago so it feels that we are going back.
We need to find a better way to present this than big blocks that stack over each other.

Maybe simply make the parent block also a float, that do not take the full screen. That way, solvers with one config will jsut have an extra gray box above with the name of the solver and multiple solver will have a box around grouping them together? Something like

[Badr-MOUFAD]

WDYT @tomMoral ?

links to preview:

• bench resnet
• bench lasso

[Badr-MOUFAD]

@bmalezieux any thoughts about #474 (comment)?

[bmalezieux]

It looks good ! I think it would be even better to add the name of the solver above solo solvers (it is what Thomas meant if I understand the drawing correctly).

[tomMoral]

Yes I like the style!! :)
As @bmalezieux said, I would keep the box above the solo solvers.
Also, could you make it so that if we fall a box, it stay the same width?

[bmalezieux]

By the way, I find it clearer to put the style in the css file rather than in the class name.

[Badr-MOUFAD]

Also, could you make it so that if we fall a box, it stay the same width?

I'm afraid it won't be possible @tomMoral.

Instead, as discussed with @bmalezieux, I made the aggregate of the solver grayish when it's disabled.

Links to to preview:

• bench resnet
• bench lasso

[mathurinm]

I'm late to the party, but instead of graying the unselected solvers, would it be possible to collapse the unselected block, displaying only its title ? If there are many solver sin a block and they're unselected, one still has to croll a lot to go to the next block