Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX pytest configuration for v7.1 #300

Merged
merged 1 commit into from Mar 14, 2022

Conversation

tomMoral
Copy link
Member

The current failure is due to a change of behavior with pytest7.1, from pytest-dev/pytest#9493.
This makes it not possible to have twice the same conftest.py

I found out that we can change this by relying on a plugin, that can be loaded at runtime with option -p in pytest.
this PR implement this as this make it cleaner (we are directly loading the installed configuration as a fixture, not relying on path resolution from pytest that we don't control very well).

Overall, this is cleaner, so hopefully the CI is green tonight.

@tomMoral
Copy link
Member Author

Merging to get a green CI :) 💚

@tomMoral tomMoral merged commit 265ca58 into benchopt:main Mar 14, 2022
@tomMoral tomMoral deleted the FIX_pytest_import branch March 14, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant