Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from LESS to SCSS for preprocessing #568

Draft
wants to merge 222 commits into
base: main
Choose a base branch
from
Draft

Conversation

rsek
Copy link
Collaborator

@rsek rsek commented Dec 21, 2022

resolves #567

WIP -- most of the migration is done, just have to hunt down the remaining broken bits and rewire them for SCSS. the bulk of the new code is additions to package-lock.json; the vast majority of the other file changes are renames, syntax adjustments for the new preprocessor, and some reordering by the new stylelint configuration.

no joy on running SASS through PostCSS -- i couldn't get it to work with custom function plugins. i might revisit that later. for the moment, SCSS compilation uses a more standard Vite config.

TODO

  • run conversion script for bulk migration of SCSS files
  • pick over all files for stuff that didn't migrate, or didn't migrate properly.
  • develop a sensible stylelint config and apply it
  • add some basic path aliases and auto-imports so that SFCs can import mixins with minimum grief
  • rewrite palettize in SCSS + JS, to take advantage of chroma-js's fancy color spaces for smarter color mixing
    • had to write a custom plugin for this. which isn't just scope creep -- SCSS doesn't have a true replacement for some of the more esoteric color functions i use in pallettize.
  • hunt down remaining migration errors (mostly box shadows and gradients)
    • SF legacy tracks now show their hover effect more reliably, and will have theme-appropriate colours generated for them at build time (via a mixin)
    • fix progress animation
    • fix roll dialog buttons (and other places where there's non-vue buttons in ironsworn applications)
  • use custom plugin instead of manual key addition to handle icon mask generation deferring to a later PR
  • Update CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate from LESS to SCSS (via PostCSS)
2 participants