Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spec-accepting overload of getFirstLevelModuleDependencies #856

Conversation

jvandort
Copy link
Contributor

This method will be deprecated soon in Gradle for removal in 9.0

The no-argument method will remain at least for the short term

This method will be deprecated soon in Gradle for removal in 9.0
@ben-manes
Copy link
Owner

Thanks! I recall using the argument for compatibility. Amusing to find that old commit

Remove guard clause due to bad method invocation.
The no-arg getFirstLevelModuleDependencies() method is only availabe
on the default implementation and is not defined on the interface for
LenientConfiguration. The anonymous implementation returned from when
any empty dependency set is used lacks this helper method, resulting
in a runtime failure. The interface method is now invoked with a
filter to collect everything.

@ben-manes ben-manes merged commit 2c7baf7 into ben-manes:master Mar 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants