Ensure Kotlin dependencies are properly handled when not forced

[tresat]

This will handle the case of Kotlin plugins (applied to the parentless classpath configuration).

[ben-manes]

odd, the test suite breaks with this change

[tresat]

You're right, this breaks additional tests.

I was getting failures in DifferentGradleVersionsSpec when I checked out master and ran build for the first time, so I assumed they weren't related. Then I didn't run the full test suite after that, since it would always fail.

I'll take another look.

[ben-manes]

iirc, that happens when you run with a newer jdk. You can use jenv, asdf, etc. to set a local one for the project. Trying right now with jdk11 on master to see if it passes locally. I don't recall what the issue was, but remember being confused by that test failure too

[ben-manes]

yep, jdk11 worked locally for master

[ben-manes]

maybe filterNot? trying locally

[ben-manes]

passes except for your new test, which I think might be a formatting difference?

PluginUpdateDetectionSpec > kotlin plugin in the implementation configuration is properly handled FAILED
    Condition not satisfied:

    result.output.contains """The following dependencies have later milestone versions: - org.jetbrains.kotlin:kotlin-gradle-plugin [$KOTLIN_VERSION -> """
    |      |      |                                                                                                                   |
    |      |      false                                                                                                               1.6.0
    |
    |      > Task :dependencyUpdates
    |
    |      ------------------------------------------------------------
    |      : Project Dependency Updates (report to plain text file)
    |      ------------------------------------------------------------
    |
    |      The following dependencies are using the latest milestone version:
    |       - org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.0
    |       - org.jetbrains.kotlin:kotlin-stdlib:1.6.0

[tresat]

I think detecting by isForced might be what's needed.

[tresat]

A little more context: I saw the comments about plugins trying to force versions, so that led me to this path. My approach to fixing this has been to preserve the special case logic for inheritedKotlin by making the smallest change that fixes these new test cases and leaving that alone.

But after talking with @jvandort, it seems isForce isn't doing anything in newer versions of Gradle, and there is no way remaining for external deps to be marked forced. So the effect of this change is to just always allow Kotlin deps to be included in that first loop that collects them into latest.

So I'm wondering if any of the special casing for Kotlin is still necessary? If I remove it all, I get the same passing build. Perhaps it is no longer useful? I couldn't find any existing tests that hinted at why it was still there. Do you know how we could create one to confirm if it is needed?

[ben-manes]

Here is the commit that introduced it, 0a290fb, which seems to be trying to fix #424.

If we don't need it anymore that is better. wdyt?

[ben-manes]

I released to unblock, but happy to revisit the removal of that code if its useless nowadays.

[tresat]

@ben-manes Can you take a look at #826 when you get a chance? I think this is all that is needed. I added tests for the kotlin stdlib dependency that was the origin of the special case in the Resolver.

[ben-manes]

that's awesome, thank you @tresat!