New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kotlin trailing lambda syntax for custom output formatters #690
Merged
vjgarciag96
merged 4 commits into
ben-manes:master
from
vjgarciag96:lambda-for-output-formatter
Sep 11, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
08237b0
Support Kotlin trailing lambda syntax for custom output formatters
vjgarciag96 79a9736
[ToSquash] Make classes marked as internal public again
vjgarciag96 5b30afc
[ToSquash] Remove unused import
vjgarciag96 3724f78
[ToSquash] Remove @JvmStatic from OutputFormatterArgument.DEFAULT
vjgarciag96 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...in/src/main/kotlin/com/github/benmanes/gradle/versions/updates/OutputFormatterArgument.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package com.github.benmanes.gradle.versions.updates | ||
|
||
import com.github.benmanes.gradle.versions.reporter.Reporter | ||
import com.github.benmanes.gradle.versions.reporter.result.Result | ||
import org.gradle.api.Action | ||
|
||
/** | ||
* Represents all the types of arguments for output formatting supported in [DependencyUpdatesTask]. | ||
*/ | ||
sealed interface OutputFormatterArgument { | ||
|
||
/** | ||
* A string representing one of the built-in output formatters (i.e. "json", "text", "html" or | ||
* "xml"), or a comma-separated list with a combination of them (e.g. "json,text"). | ||
*/ | ||
class BuiltIn(val formatterNames: String) : OutputFormatterArgument | ||
|
||
/** | ||
* An implementation of the [Reporter] interface to provide a custom output formatting. | ||
*/ | ||
class CustomReporter(val reporter: Reporter) : OutputFormatterArgument | ||
|
||
/** | ||
* An [Action] to provide a custom output formatting. Enables the use of the trailing closure/lambda | ||
* syntax for output formatting definition. | ||
*/ | ||
class CustomAction(val action: Action<Result>) : OutputFormatterArgument | ||
|
||
companion object { | ||
val DEFAULT = BuiltIn(formatterNames = "text") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be a
@JvmField
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it to be able to access this from Groovy code in tests. But I have removed it now as it is not necessary in production code.