Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Gradle 6.0 deprecations. #359

Merged
merged 2 commits into from Nov 12, 2019

Conversation

anuraaga
Copy link
Collaborator

@anuraaga anuraaga commented Nov 12, 2019

  • Groovy generates both getFoo and isFoo for boolean properties and Gradle doesn't like it anymore. So manually define getFoo to disable Groovy's generation

  • All properties must be annotated, as a reminder for task authors I guess. Annotated the properties that can be Closure as @Internal

  • Unit test now ensure we don't use deprecated stuff

Fixes #357

@ben-manes ben-manes merged commit eba6f42 into ben-manes:master Nov 12, 2019
@ben-manes
Copy link
Owner

Thank you!

I need to find the time to look into #334 before releasing. The advice of removing the workaround of disabling canBeResolved sounds promising. It just needs to be feature flagged smartly first.

@juergenzimmermann
Copy link

@ben-manes Do you see a chance for releasing a new version?

@ben-manes
Copy link
Owner

6.2 supposedly will break this plugin with a new feature, so waiting for that to release with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Gradle 6.0-rc-1
3 participants