Remove property

ben-manes · Oct 16, 2019 · 81a5d93 · 81a5d93
1 parent a6b36ae
commit 81a5d93
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.groovy b/src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.groovy
@@ -84,7 +84,7 @@ class DependencyUpdatesTask extends DefaultTask {
 
     def evaluator = new DependencyUpdates(project, resolutionStrategyAction, revisionLevel(),
       outputFormatterProp(), outputDirectory(), getReportfileName(), checkForGradleUpdate, gradleReleaseChannelLevel(),
-      checkConstraints())
+      checkConstraints)
     DependencyUpdatesReporter reporter = evaluator.run()
     reporter?.write()
   }
@@ -125,9 +125,4 @@ class DependencyUpdatesTask extends DefaultTask {
 
   /** Returns the filename of the report. */
   String getReportfileName() { System.properties.get('reportfileName', reportfileName) }
-
-  /** Returns whether constraints should have dependencies resolved. */
-  boolean checkConstraints() {
-    System.properties.containsKey('checkConstraints') || checkConstraints
-  }
 }
diff --git a/src/test/groovy/com/github/benmanes/gradle/versions/ConstraintsSpec.groovy b/src/test/groovy/com/github/benmanes/gradle/versions/ConstraintsSpec.groovy
@@ -23,6 +23,10 @@ final class ConstraintsSpec extends Specification {
           id 'com.github.ben-manes.versions'
         }
 
+        tasks.dependencyUpdates {
+          checkConstraints = true
+        }
+
         repositories {
           maven {
             url '${mavenRepoUrl}'
@@ -39,7 +43,7 @@ final class ConstraintsSpec extends Specification {
     when:
     def result = GradleRunner.create()
       .withProjectDir(testProjectDir.root)
-      .withArguments('dependencyUpdates', '-DcheckConstraints')
+      .withArguments('dependencyUpdates')
       .withPluginClasspath()
       .build()
 
@@ -59,6 +63,10 @@ final class ConstraintsSpec extends Specification {
           id 'com.github.ben-manes.versions'
         }
 
+        tasks.dependencyUpdates {
+          checkConstraints = true
+        }
+
         repositories {
           maven {
             url '${mavenRepoUrl}'
@@ -76,7 +84,7 @@ final class ConstraintsSpec extends Specification {
     when:
     def result = GradleRunner.create()
       .withProjectDir(testProjectDir.root)
-      .withArguments('dependencyUpdates', '-DcheckConstraints')
+      .withArguments('dependencyUpdates')
       .withPluginClasspath()
       .build()