Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/12224-resolve-ripple #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

belov38
Copy link
Owner

@belov38 belov38 commented Oct 5, 2021

Fixes vuetifyjs#12224

Description

Fixes vuetifyjs#12224

Motivation and Context

Provided workaround hide only error meassage, but doesn't fix ripple effect.

How Has This Been Tested?

Visually in a new vue-cli "hello world" project

Markup:

<template>
  <v-container>
    <v-simple-checkbox v-model="v" />
    <div>
      <v-data-table :headers="headers" :items="desserts" class="elevation-1">
        <template v-slot:item.glutenfree="{ item }">
          <v-simple-checkbox v-model="item.glutenfree"></v-simple-checkbox>
        </template>
      </v-data-table>
    </div>
  </v-container>
</template>

<script>
export default {
  name: "HelloWorld",

  data: () => ({
    desserts: [
      {
        name: "Eclair",
        calories: 262,
        fat: 16.0,
        carbs: 23,
        protein: 6.0,
        iron: "7%",
        glutenfree: false,
      },
      {
        name: "Jelly bean",
        calories: 375,
        fat: 0.0,
        carbs: 94,
        protein: 0.0,
        iron: "0%",
        glutenfree: true,
      },
      {
        name: "Lollipop",
        calories: 392,
        fat: 0.2,
        carbs: 98,
        protein: 0,
        iron: "2%",
        glutenfree: true,
      },
      {
        name: "KitKat",
        calories: 518,
        fat: 26.0,
        carbs: 65,
        protein: 7,
        iron: "6%",
        glutenfree: false,
      },
    ],
    headers: [
      {
        text: "Dessert (100g serving)",
        align: "start",
        sortable: false,
        value: "name",
      },
      { text: "Calories", value: "calories" },
      { text: "Fat (g)", value: "fat" },
      { text: "Carbs (g)", value: "carbs" },
      { text: "Protein (g)", value: "protein" },
      { text: "Iron (%)", value: "iron" },
      { text: "Gluten-Free", value: "glutenfree" },
    ],
    v: false,
  }),
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@@ -60,6 +60,7 @@ export default Vue.extend({
},
}), icon))

Vue.directive('ripple', ripple)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be misunderstanding - but are you globally importing the ripple directive inside a component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants