Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: supportedArchitectures set libc to current #3582

Merged
merged 1 commit into from Mar 30, 2023

Conversation

belgattitude
Copy link
Owner

@belgattitude belgattitude commented Mar 30, 2023

This allows to only install native binaries for the os/arch/libc(musl/glibc) at install time.

Why ?

  • slimmer docker install
  • keep (vercel) lambdas size sane (vercel)

See

The config:

supportedArchitectures:
  cpu:
    - current
  os:
    - current
  libc:
    - current

That helps with vercel/next.js#42641

In the future npm/pnpm might support a similar config

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

⚠️ No Changeset found

Latest commit: 50cbe6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
monorepo-nextjs-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 11:42AM (UTC)
monorepo-vite-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 11:42AM (UTC)

@codeclimate
Copy link

codeclimate bot commented Mar 30, 2023

Code Climate has analyzed commit 50cbe6d and detected 0 issues on this pull request.

View more on Code Climate.

@ghost
Copy link

ghost commented Mar 30, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@belgattitude belgattitude merged commit 25a1c0e into main Mar 30, 2023
10 of 11 checks passed
@belgattitude belgattitude deleted the yarn-supported-architecture-libc-current branch March 30, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant