Support to generate thread dump in a file #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolovison
force-pushed
the
thread_dump_path
branch
from
b451538
to
cb3e740
Compare
rhusar
requested changes
Feb 24, 2022
src/org/jgroups/util/ThreadPool.java
Outdated
| @@ -171,10 +176,26 @@ public boolean execute(Runnable task) { | |||
| catch(RejectedExecutionException ex) { | |||
| tp.getMessageStats().incrNumRejectedMsgs(1); | |||
| // https://issues.redhat.com/browse/JGRP-2403 | |||
| String threadDump = Util.dumpThreads(); | |||
There was a problem hiding this comment.
This org.jgroups.util.Util#dumpThreads call is in the wrong place. It is expensive so make sure to call it at the code path you are certainly going to use the result.
diegolovison
force-pushed
the
thread_dump_path
branch
from
cb3e740
to
1f80d1b
Compare
belaban
added a commit
that referenced
this pull request
Feb 28, 2022
|
Applied; it would be nice to have an associated JIRA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JGroups generate thread dump in the same log of the server. When dealing with suspected nodes, the logs become big and it is hard to find out the root cause.
This PR allows the developer to set a custom path to generate the thread dump.