-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#985 Don't disable existing loggers by default #986
Open
janoskut
wants to merge
1
commit into
behave:main
Choose a base branch
from
unumotors:prevent-disable-existing-loggers
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of description above:
|
No (no change needed from my side), I just wanted to clarify the point that it can be understood by others when reading the ticket. |
@jenisys is there something I can do to push this change further, like help to clarify any doubts, or add more tests? |
I am working on it. |
jenisys
force-pushed
the
main
branch
5 times, most recently
from
March 6, 2022 23:33
6508bd4
to
a4dd3fe
Compare
jenisys
force-pushed
the
main
branch
2 times, most recently
from
May 2, 2022 19:16
11ddaf9
to
5101465
Compare
Rationale: In behave, loggers are usually initialized before "before_all()" and "setup_logging()" are invoked. When using a file config, the default behavior of the logging module is to disable existing loggers (see warning in https://docs.python.org/3/howto/logging.html#configuring-logging). Changing the default behavior to not disabling the existing loggers matches behaves logger users better. By passing the **kwargs into "fileConfig()", we still allow all desired behaviors.
janoskut
force-pushed
the
prevent-disable-existing-loggers
branch
from
October 26, 2022 14:50
8f12ad1
to
7dfef97
Compare
jenisys
force-pushed
the
main
branch
3 times, most recently
from
November 6, 2022 14:11
7ec93d2
to
46ad983
Compare
jenisys
force-pushed
the
main
branch
4 times, most recently
from
April 22, 2023 17:20
fe1ca4d
to
fcfe5af
Compare
jenisys
force-pushed
the
main
branch
2 times, most recently
from
May 14, 2024 22:39
0a4d73b
to
2c11d2e
Compare
jenisys
force-pushed
the
main
branch
2 times, most recently
from
May 26, 2024 15:00
3e51dda
to
c6ab01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
In behave, loggers are usually initialized before "before_all()" and "setup_logging()" are invoked.
When using a file config, the default behavior of the logging module is to disable existing loggers (see warning in https://docs.python.org/3/howto/logging.html#configuring-logging).
Changing the default behavior to not disabling the existing loggers matches behaves logger users better.
By passing the **kwargs into "fileConfig()", we still allow all desired behaviors.