Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Sphinx <4.4.0 in CI to work around new warning #4243

Merged
merged 2 commits into from Jan 20, 2022
Merged

Pin Sphinx <4.4.0 in CI to work around new warning #4243

merged 2 commits into from Jan 20, 2022

Commits on Jan 20, 2022

  1. Pin Sphinx <4.4.0 in CI 

    A recent change in Sphinx introduced a new warning about missed extlink
opportunities:
sphinx-doc/sphinx#10112

These warnings are causing spurious CI failures. Some of these
suggestions are good but many of them are not, and there is not
currently a way to disable the warning (globally or locally). So the
only workable solution currently seems to be to pin an old version of
Sphinx in CI for now. Hopefully there will be an option to disable this
in 4.4.1, at which point we can unpin.
    @sampsyo
    sampsyo committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    cf69cad View commit details
    Browse the repository at this point in the history

  2. Move Sphinx pin to tox.ini 

    Turns out the Sphinx installed "outside" of the tox virtualenv is not
the one that actually builds the docs...
    @sampsyo
    sampsyo committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    1bcec4e View commit details
    Browse the repository at this point in the history