Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Guilded webhook regex with tests & added tests for Discord webhooks #247

Merged
merged 13 commits into from May 16, 2023

Conversation

IlluminatiFish
Copy link
Contributor

Prerequisites

Why do we need this pull request?

Adds regex for Guilded (guilded.gg) webhooks
Adds fixtures & tests for both Discord (#216) and Guilded webhooks

What GitHub issues does this fix?

Adds tests to #216

Copy / paste of output

$ pywhat "https://api.guilded.gg/webhooks/1fa5fe35-74e7-4f17-bf53-52d02293fea6/zhXzVecRvaMCWEcOCIuIMYQyeeKemUCswca24Q68cCQCgg4oYKewamAiEkaI2uCS8Q2sgwy2qUOe2c4yE2em786"
Matched on: QyeeKemUCswca24Q68cCQCgg4oYKewamAiEkaI2uCS
Name: Bitcoin Cash (BCH) Wallet Address
Link:  https://www.blockchain.com/bch/address/QyeeKemUCswca24Q68cCQCgg4oYKewamAiEkaI2uCS

Matched on: https://api.guilded.gg/webhooks/1fa5fe35-74e7-4f17-bf53-52d02293fea6/zhXzVecRvaMCWEcOCIuIMYQyeeKemUCswca24Q68cCQCgg4oYKewamAiEkaI2uCS8Q2sgwy2qUOe2c4yE2em78
Name: Guilded Webhook

Matched on: https://api.guilded.gg/webhooks/1fa5fe35-74e7-4f17-bf53-52d02293fea6/zhXzVecRvaMCWEcOCIuIMYQyeeKemUCswca24Q68cCQCgg4oYKewamAiEkaI2uCS8Q2sgwy2qUOe2c4yE2em786
Name: Uniform Resource Locator (URL)

Matched on: 1fa5fe35-74e7-4f17-bf53-52d02293fea6
Name: UUID
Link:  https://www.uuidtools.com/api/decode/1fa5fe35-74e7-4f17-bf53-52d02293fea6

Matched on: MCWEcOCIuIMYQyeeKemUCswca24Q68cCQC
Name: Litecoin (LTC) Wallet Address
Link:  https://live.blockcypher.com/ltc/address/MCWEcOCIuIMYQyeeKemUCswca24Q68cCQC

Matched on: mAiEkaI2uCS8Q2sgwy2qUOe2c4yE2em786
Name: Litecoin (LTC) Wallet Address
Link:  https://live.blockcypher.com/ltc/address/mAiEkaI2uCS8Q2sgwy2qUOe2c4yE2em786

Matched on: RvaMCWEcOCIuIMYQyeeKemUCswca24Q68c
Name: Ripple (XRP) Wallet Address
Link:  https://xrpscan.com/account/RvaMCWEcOCIuIMYQyeeKemUCswca24Q68c

Matched on: 68cCQCgg4oYKewamAiEkaI2uCS8Q2sgwy2qUOe2c
Name: Google ReCaptcha API Key
Exploit: Use the command below to verify that API key is valid:
  $ curl -X POST -d "secret=68cCQCgg4oYKewamAiEkaI2uCS8Q2sgwy2qUOe2c&response=RESPONSE_TO_VERIFY" https://www.google.com/recaptcha/api/siteverify

Added Guilded (guilded,gg) webhook regex
Added Discord webhook fixture
Added Discord webhook test
Added Guilded webhook test
Added Guilded webhook fixture
Add in-line mode specifier
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #247 (72c0be6) into main (bff6fbe) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   92.60%   92.66%   +0.06%     
==========================================
  Files          15       15              
  Lines        1217     1227      +10     
==========================================
+ Hits         1127     1137      +10     
  Misses         90       90              
Impacted Files Coverage Δ
tests/test_click.py 98.39% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff6fbe...72c0be6. Read the comment docs.

Initial commit had the list meshed together (oops)
Remove trailing comma from Guilded webhook examples
Update test function names
Hopefully fixes black formatting complaints
@bee-san
Copy link
Owner

bee-san commented Mar 4, 2022

Can you remove python 3.6 from the github action please? :)

@IlluminatiFish
Copy link
Contributor Author

IlluminatiFish commented Mar 4, 2022

Can you remove python 3.6 from the github action please? :)

This has already been done in @amadejpapez's #246 PR, might want to merge it ;)

@gaby
Copy link

gaby commented May 16, 2023

@bee-san Any chance of getting this merged?

@IlluminatiFish
Copy link
Contributor Author

@bee-san Any chance of getting this merged?

Been wondering the same thing for the last year lol

@amadejpapez amadejpapez merged commit 75a1592 into bee-san:main May 16, 2023
14 checks passed
@amadejpapez
Copy link
Collaborator

@IlluminatiFish Hey sorry about this! I see Bee has already approved it :D Merged now 👍

@IlluminatiFish
Copy link
Contributor Author

@IlluminatiFish Hey sorry about this! I see Bee has already approved it :D Merged now 👍

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants