refactor: remove unnecessary try except

bee-san · Oct 18, 2021 · 4342bdc · 4342bdc
1 parent 2f4e0cc
commit 4342bdc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/pywhat/filter.py b/pywhat/filter.py
@@ -91,14 +91,11 @@ def __len__(self):
         return len(self._dict)
 
     def __contains__(self, item):
-        try:
-            return (
-                self["MinRarity"] <= item["Rarity"] <= self["MaxRarity"]
-                and set(item["Tags"]) & self["Tags"]
-                and not set(item["Tags"]) & self["ExcludeTags"]
-            )
-        except KeyError:
-            return False
+        return (
+            self["MinRarity"] <= item["Rarity"] <= self["MaxRarity"]
+            and set(item["Tags"]) & self["Tags"]
+            and not set(item["Tags"]) & self["ExcludeTags"]
+        )
 
     def setdefault(self, key, default=None):
         return self._dict.setdefault(key, default)

diff --git a/tests/test_filtration.py b/tests/test_filtration.py
@@ -149,8 +149,3 @@ def test_filter3():
             and "Identifiers" not in regex["Tags"]
         ):
             assert regex in dist.get_regexes()
-
-
-def test_invalid_contains_returns_false():
-    filter = Filter()
-    assert ({} in filter) is False