Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix psf/black package version #1996

Merged

Conversation

mhnaeem
Copy link
Contributor

@mhnaeem mhnaeem commented Mar 6, 2022

Description

The latest release of black has introduced breaking changes which affect the ci pipeline and python test. Specify a version for download until that can be fixed.

Fixes Issue:
#1995

The latest release of black has introduced breaking changes which affect the ci pipeline and python test. Specify a version for download until that can be fixed. beautifier#1995
@bitwiseman
Copy link
Member

Instead of locking the version, perhaps you could run the new version and apply the changes?

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can avoid locking to an old version it would be better.

@mhnaeem
Copy link
Contributor Author

mhnaeem commented Mar 9, 2022

Instead of locking the version, perhaps you could run the new version and apply the changes?

@bitwiseman I am not 100% familiar with the usage of that tool but according to their release notes for the v22.1.0 they removed entire support for Python 2. So the fix here would be to use an alternative package or stop running Python2 by removing 'py27' from the target versions in python/pyproject.toml.

See link for more info: psf/black#2740

@bitwiseman
Copy link
Member

It is probably time for this tool to remove python 2 support. Would you be willing to make that change?

@mhnaeem
Copy link
Contributor Author

mhnaeem commented Mar 13, 2022

Would you be willing to make that change?

@bitwiseman I am not entirely sure what is required to make that possible. I will be happy to contribute some time if there is a well defined list of issues or things that need done.

@bitwiseman bitwiseman merged commit 83f1bec into beautifier:main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants