Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errors package #692

Merged
merged 1 commit into from
May 4, 2024
Merged

Remove errors package #692

merged 1 commit into from
May 4, 2024

Conversation

mantzas
Copy link

@mantzas mantzas commented May 4, 2024

Which problem is this PR solving?

Remove errors package.

Short description of the changes

Remove errors package and use errors.Join from std.

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 79.44%. Comparing base (51835d0) to head (8c61a9f).

Files Patch % Lines
client/amqp/amqp.go 0.00% 2 Missing ⚠️
component/amqp/component.go 33.33% 2 Missing ⚠️
client/kafka/async_producer.go 0.00% 1 Missing ⚠️
client/kafka/sync_producer.go 0.00% 1 Missing ⚠️
component/http/route_option.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   79.56%   79.44%   -0.13%     
==========================================
  Files          69       68       -1     
  Lines        4082     4067      -15     
==========================================
- Hits         3248     3231      -17     
- Misses        684      685       +1     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mantzas mantzas marked this pull request as ready for review May 4, 2024 15:14
@mantzas mantzas merged commit e3d70f5 into master May 4, 2024
3 of 5 checks passed
@mantzas mantzas deleted the remove-errors branch May 4, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant