Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed deprecated use of Logger.warn #57

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

David-Klemenc
Copy link
Contributor

resolves #56

Upon compiling I got an error for the jason library which is imported by the excoveralls library - bumping the excoveralls version fixed the problem.

The Logger.warning/2 function was added to Elixir in 1.11.0 and deprecated in version 1.15.0 so I bumped the project elixir version from 1.10.0 to 1.11.0.

bryannaegele
bryannaegele previously approved these changes Oct 1, 2023
@bryannaegele
Copy link
Collaborator

I had to fix the ci workflow. Can you rebase and push?

@David-Klemenc
Copy link
Contributor Author

P.S. The updated deps should also get rid of makeup_erlang warning:

==> makeup_erlang
Compiling 3 files (.ex)
warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
Warning:   lib/makeup/lexers/erlang_lexer.ex:250: Makeup.Lexers.ErlangLexer (module)

@bryannaegele
Copy link
Collaborator

To fix the Dialyzer issue, it needs to be pinned to the last 1.13 release.

jeremyjh/dialyxir#514

@David-Klemenc
Copy link
Contributor Author

David-Klemenc commented Oct 2, 2023

I created another PR there: jeremyjh/dialyxir#519 😄

And it was merged 🎊

bryannaegele
bryannaegele previously approved these changes Dec 19, 2023
@bryannaegele bryannaegele merged commit 9e8f3be into beam-telemetry:main Jan 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Logger.warn/1 is deprecated
2 participants