Replace keycloak-connect protect method with jsonwebtoken.verify #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
requested review from
norrisng-bc,
jatindersingh93,
wilwong89 and
kyle1morel
as code owners
Coverage Report
|
TimCsaky
requested review from
norrisng-bc
and removed request for
wilwong89 and
kyle1morel
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TimCsaky
force-pushed
the
chore/remove-keyclaok-connect
branch
from
d99be42
to
b1fa2a1
Compare
jatindersingh93
approved these changes
Apr 16, 2024
norrisng-bc
approved these changes
Apr 16, 2024
We can use the verify() method that comes with the jsonwebtoken library to verify the client's auth token is valid. An invalid token will now return a Problem instance Updated API spec
TimCsaky
force-pushed
the
chore/remove-keyclaok-connect
branch
from
b1fa2a1
to
c8559dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3500
This PR will need regression testing before merging
Types of changes
Code simplification
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments