936 change id to UUID #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sepehr-Sobhani
force-pushed
the
936-change-id-to-uuid
branch
2 times, most recently
from
046ac6b
to
b3fc3ae
Compare
Sepehr-Sobhani
force-pushed
the
936-change-id-to-uuid
branch
from
72ff2b4
to
9a89e98
Compare
dleard
approved these changes
Feb 21, 2024
| @@ -66,6 +66,7 @@ export default async function Page() { | |||
| ]; | |||
|
|
|||
| const statusRows: GridRowsProp = userOperatorStatuses.map((uOS) => ({ | |||
| id: uOS.id, // This unique ID is needed for DataGrid to work properly | |||
There was a problem hiding this comment.
👍
We should also remove lines 14-20 above, showing the guid in the table is not helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 936
AND
ISSUE 822
AND
An issue with the Admin Requests Table which was not showing up because of removing
idattribute in recent changes.NOTE:
orjsonpackage as it doesn't support 128-bit integers so we can't get UUIDs to work.(128-bit integers ijl/orjson#116 (comment))