Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing audit CI step #671

Merged
merged 1 commit into from May 20, 2020
Merged

Fix failing audit CI step #671

merged 1 commit into from May 20, 2020

Conversation

dleard
Copy link
Contributor

@dleard dleard commented May 20, 2020

  • Fixes https://www.npmjs.com/advisories/1219
  • I may have done a bad bad thing, or at least this is worth watching as no new version is currently available that is unaffected. So I have rolled this package back to the last unaffected version, which is a beta from a year ago.

This package is only used by storybook

@matthieu-foucault
Copy link
Contributor

@dleard I think that the version you chose is technically affected, but wasn't analyzed by npm as it's a beta. I expect a patch would be released soon given the impact

@matthieu-foucault
Copy link
Contributor

see quantizor/markdown-to-jsx#306

@dleard
Copy link
Contributor Author

dleard commented May 20, 2020

@matthieu-foucault So is rolling back to this un-analyzed version in order to continue to merge things fine until there is a patch?

@matthieu-foucault
Copy link
Contributor

Yeah. I subscribed to the issue linked above to see how things go

@dleard dleard merged commit 1ebd856 into develop May 20, 2020
@dleard dleard deleted the fix/ci-audit-fail branch May 20, 2020 18:19
@matthieu-foucault matthieu-foucault temporarily deployed to wksv3k-dev May 23, 2020 14:58 — with BC CAS Shipit Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants