Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Compatibility with PHP8.1 #16

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bbrothers
Copy link
Owner

Description

This PR extracts the PHPUnit assertion logic into the Muzzle\Assertions\Assert class so that assertion logic can be kept to the Assert class. It also restricts the PHPUnit version to 8.0 for now while we wait for the 8.1 bug (sebastianbergmann/phpunit#3599) to be resolved.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants