New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the StubSocket slightly more believable #988

Merged

bblimke merged 4 commits into bblimke:master from rzane:socket-methods

Aug 5, 2022

Contributor

rzane commented Aug 5, 2022 •

edited

Fixes #976 (comment)

ActiveMerchant expects #ssl_version and #cipher to be defined. Though these methods are private, it's best if webmock can try to act like the Net::HTTP to avoid gems having to detect if WebMock is enabled.
I also took the opportunity to make StubSocket#close and StubSocket#closed? a bit more realistic as well.
I also noticed that Net::HTTP#ipaddr was broken because StubSocket#peeraddr wasn't defined.

rzane added 4 commits

August 5, 2022 00:42


          Make StubSocket#close work as one might expect

cadef36


          Fix broken Net::HTTP#ipaddr

0eb3a7b


          Implement ssl_version and cipher on the StubSocket

5abd2f5


          Net::HTTP#ipaddr was added in 2.7

786cd11

Owner

bblimke commented Aug 5, 2022

Thank you @rzane . Awesome!

bblimke merged commit fc798ea into bblimke:master

rzane deleted the socket-methods branch

August 5, 2022 20:51

rzane mentioned this pull request

Simplify Net::HTTP connection handing #992

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment