Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start connection in Net::HTTP adapter for mocked requests #960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Start connection in Net::HTTP adapter for mocked requests #960

wants to merge 1 commit into from

Commits on Dec 10, 2021

  1. Start connection in Net::HTTP adapter for mocked requests 

    Instrumentation like Sentry only instruments requests when
`Net::HTTP.started?` because `#request` is called twice if connection
is not started yet. This change allows this instrumentation to work
with mocked requests.

See https://github.com/ruby/net-http/blob/master/lib/net/http.rb#L1529-L1534
    @ojab
    ojab committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    181d206 View commit details
    Browse the repository at this point in the history