Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async http adapter #901

Merged
merged 1 commit into from Sep 11, 2020
Merged

Commits on Sep 8, 2020

  1. Fix async http adapter

    Problem: the server in Async::HTTP::WebMockEndpoint#accept_socket was
    hanging forever after the rspec example finished.
    This is normal as Async::HTTP::Server (or any server) is never supposed
    to end. It just continues waiting for new requests which, in this case,
    never come.
    
    Solution: use a 'transient' async task when starting a server.
    Transient tasks do not block an exiting async reactor.
    So, in this case a transient server will not hang forever.
    
    Fixes bblimke#858
    bruno- committed Sep 8, 2020
    Copy the full SHA
    09cde87 View commit details
    Browse the repository at this point in the history