disable TracePoint properly #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `super` raise an exception, this very danger TracePoint is not disabled. This is why https://bugs.ruby-lang.org/issues/15400 This change is introduced at: bblimke#751 Anyway, this approach is very danger (for example, `tmp` variable name is not exposed API), so that pls re-consider to use this technique.
hanachin
reviewed
Dec 12, 2018
| @@ -285,7 +285,7 @@ def rbuf_fill | |||
| end | |||
|
|
|||
| super | |||
|
|
|||
| ensure | |||
There was a problem hiding this comment.
In Ruby 2.6, the TracePoint#enable takes target: keyword argument.
We can use TracePoint#enable with the target: to enable the TracePoint for the specific method.
What do you think?
trace.enable(target: WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetBufferedIO.instance_method(:rbuf_fill)) do
super
endThere was a problem hiding this comment.
you == me?
It is better. But I think this TracePoint approach is danger, even with this limitation.
|
Any thoughts of how to avoid using trace point to achieve the same behaviour? |
|
Not sure because I don't know about |
|
ping? it might be better to remove tracepoint, but merging this would unblock our 2.6 testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
superraise an exception, this very danger TracePoint is not disabled.This is why https://bugs.ruby-lang.org/issues/15400
This change is introduced at: #751
Anyway, this approach is very danger (for example,
tmpvariable name is not exposed API), so that pls re-consider to use this technique.