Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert query values to strings before comparison #517

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

convert query values to strings before comparison #517

wants to merge 5 commits into from

Commits on Sep 17, 2015

  1. convert query values to strings before comparison

    @davidbegin
    davidbegin committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    9510402 View commit details
    Browse the repository at this point in the history

  2. spec for converting keys to symbols when Mocking

    @davidbegin
    davidbegin committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    0eef3cd View commit details
    Browse the repository at this point in the history

  3. Refactor out .convert_query_string_into_array 

       this commit refactors out a new private class method
  .convert_query_string_into_array from the .values_to_query method
  in WebMock::Util::QueryMapper
    @davidbegin
    davidbegin committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    07b906f View commit details
    Browse the repository at this point in the history

  4. clean up some private QueryMapper internals 

      rename private class method
  convert_query_string_into_array => .convert_query_hash_to_array
    @davidbegin
    davidbegin committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    0678821 View commit details
    Browse the repository at this point in the history

  5. Converts to string for comparing w/ hash_including 

      This change updates so the expected request and actual request,
  are compared to as strings, when using hash_including
    @davidbegin
    davidbegin committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    08a3a4a View commit details
    Browse the repository at this point in the history