Add net_http_connect_on_start example with explicit domain #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to workaround the `net_http_connect_on_start` gotcha while working with Capybara it's sometimes necessary to restrict the scope of `net_http_connect_on_start`. This adds information from [this comment](bblimke#914 (comment)) to the readme to make debugging that issue easier, and adds an example to show `net_http_connect_on_start` accepts domains as well as boolean values.
|
@spikeheap I have just encountered this situation and I think your addition to the README makes a lot of sense. I'm sure this will save others time as well. Thanks for your blog post on the topic: https://ryanbrooks.co.uk/posts/2023-01-17-capybara-webmock-allow-http.html @bblimke @myronmarston Is there a chance you can review and merge this within the next days/weeks? Thanks a lot. @silvermind FYI |
|
There doesn't seem to be appetite for this PR, so closing to clean up my PR list. No worries 🙇 |
|
@spikeheap really sorry for not getting to your PR sooner. Thank you for the PR. That's super useful. Also really appreciated your blog post. Thanks for all the effort you put in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the
net_http_connect_on_startgotcha with Capybara I found it's sometimes necessary to restrict the scope ofnet_http_connect_on_startto prevent network connections to external services while allowing (and fixing) connections to the local test server.This PR pulls information from this comment into the readme and adds an example to show
net_http_connect_on_startaccepts domains as well as boolean values, which resolved the issue for me.