Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on ruby 2.7 #861

Open
zenspider opened this issue Nov 22, 2019 · 3 comments
Open

Broken on ruby 2.7 #861

zenspider opened this issue Nov 22, 2019 · 3 comments

Comments

@zenspider
Copy link
Contributor

zenspider commented Nov 22, 2019

I've put in a PR (#860) to fix up a lot of the deprecation warnings but I haven't the time or understanding to dig into the actual failures. Looks like CI has been red for a while tho.

ETA: 2.7 comes out in mere weeks...

@kzkn
Copy link

kzkn commented Jan 9, 2020

One of reason: httprb/http#582
This causes some errors like below:

  1) HTTP.rb with WebMock allows a response with multiple values for the same header to be recorded and played back exactly as-is
     Failure/Error: webmock_response.body    = body.to_s
     
     FrozenError:
       can't modify frozen String: ""
     Shared Example Group: "complex cross-concern behaviors" called from ./spec/acceptance/webmock_shared.rb:39
     Shared Example Group: "with WebMock" called from ./spec/acceptance/http_rb/http_rb_spec.rb:10
     # /home/travis/.rvm/gems/ruby-2.7.0/gems/http-4.2.0/lib/http/response/body.rb:52:in `force_encoding'
(snip)

@ixti
Copy link
Contributor

ixti commented Jan 9, 2020

We just released http-4.3.0 that brings ruby-2.7 support.

@kzkn
Copy link

kzkn commented Jan 10, 2020

Broken specs have fixed.
https://travis-ci.org/bblimke/webmock/jobs/634932029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants