Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breakage on ruby 2.7 #4669

Closed
zenspider opened this issue Nov 4, 2019 · 4 comments
Closed

Fix breakage on ruby 2.7 #4669

zenspider opened this issue Nov 4, 2019 · 4 comments
Assignees
@james-stocks
Labels
Aspect: Correctness Is it actually right? Does it match a specification? Epic Priority: Medium Should be addressed in 3 business days Type: Bug Feature not working as expected Type: Epic
Milestone
Sprint - 2019-12-27

Comments

@zenspider
Copy link
Contributor

We have 2.7 running on CI but it is a soft failure and is breaking in many areas.
@zenspider zenspider added Type: Bug Feature not working as expected Aspect: Correctness Is it actually right? Does it match a specification? labels Nov 4, 2019
@kekaichinose kekaichinose added the Priority: Medium Should be addressed in 3 business days label Nov 8, 2019
@zenspider zenspider self-assigned this Nov 22, 2019
@zenspider
Copy link
Contributor Author

zenspider commented Nov 22, 2019 •
edited

Upstreams:

In Progress

flori/json#388 or flori/json#389 (merged and backported, but not released)

Done

bblimke/webmock#861 => bblimke/webmock#860 (merged)

fbernier/tomlrb#22 (merged! & released!!!)

piotrmurach/strings#9 => piotrmurach/strings#10 (merged & released)

piotrmurach/necromancer#6 -> piotrmurach/necromancer#7 (merged & released)

lostisland/faraday#1009 (merged & released!)

@zenspider zenspider mentioned this issue Nov 25, 2019
Merged
@clintoncwolfe clintoncwolfe added this to the Sprint - 2019-11-27 milestone Nov 26, 2019
@zenspider zenspider assigned kekaichinose and unassigned zenspider Dec 3, 2019
@kekaichinose
Copy link
Contributor

@james-stocks not sure if this helps, but this was the epic for Ruby 2.7 work. It seemed to have some upstream dependencies that I'm unsure the status of. Not sure if this helps

@kekaichinose
Copy link
Contributor

Just chatted with @james-stocks and he'll follow up on this as we think this work has already been completed.

@james-stocks
Copy link
Contributor

I checked yesterday, Ruby 2.7 is now running and passing in CI for every commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james-stocks james-stocks

Labels
Aspect: Correctness Is it actually right? Does it match a specification? Epic Priority: Medium Should be addressed in 3 business days Type: Bug Feature not working as expected Type: Epic
Projects
None yet
Milestone
Sprint - 2019-12-27
Development

No branches or pull requests
4 participants
@zenspider @clintoncwolfe @james-stocks @kekaichinose