Prevent Net/ReadTimeout error in Ruby 2.6
#751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
prevent_net_readtimeout_error_in_ruby_2_6
branch
from
50eac69
to
c1badcf
Compare
This PR fixes the following build error in Ruby 2.6.0 (ruby-head).
```console
$ ruby --version
ruby 2.6.0dev (2018-03-07 trunk 62693) [x86_64-linux]
% bundle exec rake
(snip)
1) Net:HTTP with WebMock when net connect is allowed should make a
real https request if request is not stubbed
Failure/Error: response = super(request, nil, &nil)
Net::ReadTimeout:
Net::ReadTimeout
Shared Example Group: "allowing and disabling net connect" called
from ./spec/acceptance/webmock_shared.rb:25
Shared Example Group: "with WebMock" called from
./spec/acceptance/net_http/net_http_spec.rb:10
# ./lib/webmock/http_lib_adapters/net_http.rb:97:in `block in
request'
# ./lib/webmock/http_lib_adapters/net_http.rb:105:in `block in
request'
# ./lib/webmock/http_lib_adapters/net_http.rb:137:in
`start_with_connect_without_finish'
# ./lib/webmock/http_lib_adapters/net_http.rb:104:in `request'
# ./spec/acceptance/net_http/net_http_spec_helper.rb:35:in `block
in http_request'
# ./lib/webmock/http_lib_adapters/net_http.rb:123:in
`start_without_connect'
# ./lib/webmock/http_lib_adapters/net_http.rb:150:in `start'
# ./spec/acceptance/net_http/net_http_spec_helper.rb:34:in
`http_request'
#
./spec/acceptance/shared/allowing_and_disabling_net_connect.rb:14:in
`block (4 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# Net::ReadTimeout:
# Net::ReadTimeout
# ./lib/webmock/http_lib_adapters/net_http.rb:97:in `block in
request'
(Errors continue after this)
```
https://travis-ci.org/bblimke/webmock/jobs/350668167#L942-L1202
This is because it was changed to use `IO#read_nonblock` based on the
value of `@rbuf` by the following commit.
ruby/ruby@b02fc0f
This PR forces the 2nd argument `tmp` of `IO#read_nonblock` to `nil` by using
`TracePoint`. So this prevents `Net::ReadTimeout` from occurring.
koic
force-pushed
the
prevent_net_readtimeout_error_in_ruby_2_6
branch
from
c1badcf
to
1cc36e5
Compare
|
@koic Clever! Thank you. |
ko1
added a commit
to ko1/webmock
that referenced
this pull request
Dec 12, 2018
if `super` raise an exception, this very danger TracePoint is not disabled. This is why https://bugs.ruby-lang.org/issues/15400 This change is introduced at: bblimke#751 Anyway, this approach is very danger (for example, `tmp` variable name is not exposed API), so that pls re-consider to use this technique.
tagliala
added a commit
to Coveralls-Community/coveralls-ruby
that referenced
this pull request
Dec 26, 2018
Tests against Ruby 2.6 are going to fail. May be related to bblimke/webmock#751
tagliala
added a commit
to Coveralls-Community/coveralls-ruby
that referenced
this pull request
Dec 26, 2018
Tests against Ruby 2.6 are going to fail. May be related to bblimke/webmock#751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following build error in Ruby 2.6.0 (ruby-head).
https://travis-ci.org/bblimke/webmock/jobs/350668167#L942-L1202
This is because it was changed to use
IO#read_nonblockbased on the value of@rbufby the following commit.ruby/ruby@b02fc0f
This PR forces the 2nd argument
tmpofIO#read_nonblocktonilby usingTracePoint. So this preventsNet::ReadTimeoutfrom occurring.