Merge pull request #1038 from instrumentl/typhoeus-timings

Set Typhoeus timing fields when constructing Response objects
bblimke · Feb 5, 2024 · 019aecc · 019aecc
2 parents 2cb15eb + 5726636
commit 019aecc
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/webmock/http_lib_adapters/typhoeus_hydra_adapter.rb b/lib/webmock/http_lib_adapters/typhoeus_hydra_adapter.rb
@@ -96,15 +96,29 @@ def self.generate_typhoeus_response(request_signature, webmock_response)
               status_message: "",
               body: "",
               headers: {},
-              return_code: :operation_timedout
+              return_code: :operation_timedout,
+              total_time: 0.0,
+              starttransfer_time: 0.0,
+              appconnect_time: 0.0,
+              pretransfer_time: 0.0,
+              connect_time: 0.0,
+              namelookup_time: 0.0,
+              redirect_time: 0.0
             )
           else
             ::Typhoeus::Response.new(
               code: webmock_response.status[0],
               status_message: webmock_response.status[1],
               body: webmock_response.body,
               headers: webmock_response.headers,
-              effective_url: request_signature.uri
+              effective_url: request_signature.uri,
+              total_time: 0.0,
+              starttransfer_time: 0.0,
+              appconnect_time: 0.0,
+              pretransfer_time: 0.0,
+              connect_time: 0.0,
+              namelookup_time: 0.0,
+              redirect_time: 0.0
             )
           end
           response.mock = :webmock

diff --git a/spec/acceptance/typhoeus/typhoeus_hydra_spec.rb b/spec/acceptance/typhoeus/typhoeus_hydra_spec.rb
@@ -29,6 +29,15 @@
           expect(response.body).not_to be_nil
           expect(response.headers).not_to be_nil
           expect(response.effective_url).not_to be_nil
+          expect(response.total_time).to eq 0.0
+          expect(response.time).to eq 0.0  # aliased by Typhoeus::Response::Informations
+          expect(response.starttransfer_time).to eq 0.0
+          expect(response.start_transfer_time).to eq 0.0  # aliased by Typhoeus::Response::Informations
+          expect(response.appconnect_time).to eq 0.0
+          expect(response.pretransfer_time).to eq 0.0
+          expect(response.connect_time).to eq 0.0
+          expect(response.namelookup_time).to eq 0.0
+          expect(response.redirect_time).to eq 0.0
         end
       end