Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add Top story promo styling to existing story promo component #578

Merged
merged 25 commits into from Jun 17, 2019
Merged

Add Top story promo styling to existing story promo component #578

merged 25 commits into from Jun 17, 2019

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Jun 5, 2019

Resolves #572

Overall change: Adds styles for top story promo, a variation on the regular story promo

Code changes:

  • Adds custom styling based on a prop to alter the styles if a story is the 'top story'
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 added ws-home Tasks for the WS Home Team ws-fp-v1 labels Jun 5, 2019
@dr3 dr3 self-assigned this Jun 5, 2019
@dr3 dr3 added this to PR in Progress in Simorgh via automation Jun 5, 2019
@dr3 dr3 moved this from PR in Progress to 1st Code review in Simorgh Jun 5, 2019
Simorgh automation moved this from 1st Code review to PR in Progress Jun 5, 2019
Drew McMillan and others added 4 commits June 5, 2019 13:08
@DenisHdz
Update packages/components/psammead-story-promo/src/index.test.jsx
7c9d179 
Co-Authored-By: Denis Hernandez <46446236+DenisBBC@users.noreply.github.com>
@DenisHdz
Update packages/components/psammead-story-promo/src/index.test.jsx
0dc59d9 
Co-Authored-By: Denis Hernandez <46446236+DenisBBC@users.noreply.github.com>
Update snaps
587bdcd
eslint
66358c6
@dr3 dr3 moved this from PR in Progress to 1st Code review in Simorgh Jun 5, 2019
DenisHdz
DenisHdz previously approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💅🏼

@dr3 dr3 moved this from 1st Code review to 2nd Code review in Simorgh Jun 6, 2019
ghost
ghost previously approved these changes Jun 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@DenisHdz DenisHdz moved this from 2nd Code review to Ready for Test in Simorgh Jun 6, 2019
@david-boydell david-boydell moved this from Ready for Test to In Test in Simorgh Jun 11, 2019
@dr3 dr3 dismissed stale reviews from ghost and DenisHdz via 524576a June 12, 2019 10:51
DenisHdz
DenisHdz approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💃🏻

@dr3 dr3 requested a review from pjlee11 June 13, 2019 17:28
@dr3 dr3 moved this from Code review to Ready for Test in Simorgh Jun 14, 2019
pjlee11
pjlee11 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@pjlee11 pjlee11 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-nowak andrew-nowak added this to the Story Promo (WS FP) milestone Jun 14, 2019
@DenisHdz
Copy link
Contributor

This PR now has conflicts

@david-boydell david-boydell moved this from Ready for Test to In Test in Simorgh Jun 17, 2019
@david-boydell
Copy link

Hi @dr3 , the font-size/line-height at 599px (and below) is 16/20. In Zeplin the sizes required are 20/24, could these be updated please?

@david-boydell
Copy link

david-boydell commented Jun 17, 2019 •
edited

Apologies, I'll need to check with UX what these values should be - there seems to be two variants at different widths but it's not clear what the boundaries are - hold off for now @dr3

@david-boydell
Copy link

Hi @dr3 , I've had word back from UX. The font sizes for the Top Story component should be as follows:

599-320px width: headline 22/26 and summary 15/18.
<320px: headline 20/24 and summary 15/18.

@david-boydell david-boydell moved this from In Test to Ready for dev in Simorgh Jun 17, 2019
@dr3 dr3 moved this from Ready for dev to PR in Progress in Simorgh Jun 17, 2019
@david-boydell david-boydell self-assigned this Jun 17, 2019
@clareevansbbc clareevansbbc removed this from the Story Promo (WS FP) milestone Jun 17, 2019
@dr3 dr3 moved this from PR in Progress to Code review in Simorgh Jun 17, 2019
Simorgh automation moved this from Code review to Ready for Test Jun 17, 2019
@david-boydell
Copy link

This looks good, ready for merge.

@david-boydell david-boydell moved this from Ready for Test to In Test in Simorgh Jun 17, 2019
@david-boydell david-boydell moved this from In Test to Ready for merge in Simorgh Jun 17, 2019
@dr3 dr3 merged commit 026d76b into latest Jun 17, 2019
Simorgh automation moved this from Ready for merge to Done Jun 17, 2019
@dr3 dr3 deleted the TopStoryPromo branch June 17, 2019 14:21
@dr3 dr3 mentioned this pull request Jun 17, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjlee11 pjlee11 pjlee11 approved these changes

@DenisHdz DenisHdz DenisHdz approved these changes

@j-pendlebury j-pendlebury j-pendlebury left review comments

@sareh sareh Awaiting requested review from sareh

Assignees

@dr3 dr3

@david-boydell david-boydell

Labels
high priority ws-home Tasks for the WS Home Team
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reuse Story Promo component for the Top Story Promo
8 participants
@dr3 @DenisHdz @david-boydell @pjlee11 @j-pendlebury @andrew-nowak @clareevansbbc @jamesbrumpton