This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Bump babel/cli to 7.8.3 and remove --configFile option from build script #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amywalkerdev
changed the title
amywalkerdev
added
ws-home
12
approved these changes
Jan 22, 2020
DenisHdz
approved these changes
Jan 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Bumps @babel/cli from 7.7.0 to 7.8.3 and removes the --configFile option from the package build scripts.
Babel suggests the use of kebabcase in its command line options, and version 7.7.4 of the cli fixes an issue where unknown options would silently fail (babel/babel#10698). I think this means that our use of
--configFile babel.config.jshas actually been ignored for a while now and it has just been defaulting to our config file in the root anyway. Removing this option, the packages still seem to build as they used to and components look ok in storybook.Code changes: