Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projectile-recentf with inactive project (#1881) #1882

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix projectile-recentf with inactive project (#1881) #1882

merged 1 commit into from
Feb 11, 2024

Conversation

gessen
Copy link
Contributor

@gessen gessen commented Feb 11, 2024

projectile-recentf-files expands recentf files to use canonicalized versions, /home/example/project instead of ~/project. However, if the project is not active and projectile-recentf was called, it would return non-canonicalized directory which then fails the comparison with recentf list.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

projectile-recentf-files expands recentf files to use canonicalized
versions, /home/example/project instead of ~/project. However, if the
project is not active and projectile-recentf was called, it would return
non-canonicalized directory which then fails the comparison with recentf
list.
@bbatsov bbatsov merged commit 375a63b into bbatsov:master Feb 11, 2024
6 of 7 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Feb 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants