If the file already exists, attempt to navigate to it directly instea… #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of running extra logic.
|
Fine by me. Just mention this in the changelog, please. |
|
Thanks for taking a look at this. I've updated the The CI failure here: https://github.com/bbatsov/projectile/actions/runs/7499131904/job/20416035012 doesn't seem to be related to my changes, or could it be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR proposes to improve how
compilation-find-file-projectile-find-compilation-bufferworks by directly navigating to the file if already present on disk. On projects with a very large number of directories (i.e. where the projectile cache exceeds 2GB, as is common when working on Unreal projects), this can make the difference between navigating to a file from the compilation buffer instantly VS waiting for potentially upwards of 30s.