Get GOROOT config from "go env" #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In typical cases, this gives the same result as the existing logic. On my system, "go env" gives the correct answer and the existing logic does not. I use the [nix package manager](https://nixos.org/) to manage my packages, including go. As a result, the go program in my PATH is a symlink. If you go up two directories from it, you get the directory containing all of my installed packages, not the go installation directory. But if you call `go env GOROOT`, it prints the correct path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typical cases, this gives the same result as the existing logic.
On my system, "go env" gives the correct answer and the existing logic
does not.
I use the nix package manager to manage my
packages, including go. As a result, the go program in my PATH is a
symlink. If you go up two directories from it, you get the directory
containing all of my installed packages, not the go installation
directory. But if you call
go env GOROOT, it prints the correct path.